e2e: fix junit token warnings for sonobuoy #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The if logic here seems to work but it still does not correctly upload the JUnit files: I guess this was broken before? Might have to investigate. I'll keep the PR open right now, hopefully this should be a relatively quick fix. |
Nirusu
force-pushed
the
ref/e2e-checks-write
branch
from
e988018 to
c346f28
Compare
katexochen
approved these changes
Mar 20, 2023
Nirusu
force-pushed
the
ref/e2e-checks-write
branch
from
c346f28 to
d8bc453
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
See: https://github.com/edgelesssys/constellation/actions/runs/4414262630
This PR fixes this issue by adding the required permission + only enabling JUnit upload whenever we do "sonobuoy full", given that only then sonobuoy actually outputs a junit file.