Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: Bump SDK to v3.1.1 #673

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented May 24, 2024

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-mqtt-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
@cloudxxx8 cloudxxx8 requested a review from cherrycl May 24, 2024 07:52
Copy link

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.92%. Comparing base (6c8369b) to head (0dd432c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             napa     #673   +/-   ##
=======================================
  Coverage   21.92%   21.92%           
=======================================
  Files           5        5           
  Lines         488      488           
=======================================
  Hits          107      107           
  Misses        367      367           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit 7a6fdf0 into edgexfoundry:napa May 24, 2024
3 checks passed
@cloudxxx8 cloudxxx8 deleted the bump-sdk-3.1.1 branch May 24, 2024 08:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants