Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Delay in obtaining DeviceStatus for pre-defined and manually added devices #121

Closed
ajcasagrande opened this issue Jul 26, 2022 · 1 comment · Fixed by #182
Closed

Delay in obtaining DeviceStatus for pre-defined and manually added devices #121

ajcasagrande opened this issue Jul 26, 2022 · 1 comment · Fixed by #182
Labels
2-medium priority denoting issues with cross-cutting project impact bug Something isn't working
Milestone
Levski

Comments

@ajcasagrande
Copy link
Contributor

🐞 Bug Report

Affected Services [REQUIRED]

device-onvif-camera

Is this a regression?

No

Description and Minimal Reproduction [REQUIRED]

When a device is added either via pre-defined devices in camera.toml, or via the core-metadata REST API, the device will lack a DeviceStatus until the next time the checkStatuses job is run.

In the case of pre-defined devices (using default configuration) this can be up to 45 seconds after service startup. In the case of REST API, it can be up to 30 seconds.

🌍 Your Environment

Deployment Environment:
Docker + EdgeX-Compose

EdgeX Version [REQUIRED]:
2.2

Anything else relevant?
@ajcasagrande ajcasagrande added the bug Something isn't working label Jul 26, 2022
@ajcasagrande ajcasagrande mentioned this issue Jul 26, 2022
Merged
5 tasks
@lenny-goodell lenny-goodell added the 2-medium priority denoting issues with cross-cutting project impact label Sep 29, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Sep 29, 2022
Merged
5 tasks
presatish pushed a commit that referenced this issue Oct 27, 2022
@ChristianDarr-personal @ajcasagrande
fix: status delay #121 (#182)
55762a2 
* feat: add check status call for newly added devices

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>

* feat: add status immediately for pre-defined devices

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* fix: remove control plane device check

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* feat: single test case for connnectionMethods

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* docs: remove outdated todo comment

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* test: add tcpProbe tests

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* fix: remove commented code and fix comments

Signed-off-by: Darr, Christian <christian.darr@intel.com>

* fix: call checkStatus before createOnvifClient in addDevice

Signed-off-by: Christian Darr <christian.darr@intel.com>

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Darr, Christian <christian.darr@intel.com>
Signed-off-by: Christian Darr <christian.darr@intel.com>
Co-authored-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@vyshali-chitikeshi
Copy link
Contributor

Verified that retrieving device status not taking 30 seconds or 45 seconds longer with images on 10/28/22.
Tested with predefined devices in configuraiton.toml file and adding devices manually with curl command. In both cases, noticed that device status called within 1 or 2 secs after services are up or after adding device manually with curl command.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
2-medium priority denoting issues with cross-cutting project impact bug Something isn't working
Projects
None yet
Milestone
Levski
Development

Successfully merging a pull request may close this issue.

fix: status delay #121 EdgeX-Camera-Management/device-onvif-camera
3 participants
@lenny-goodell @ajcasagrande @vyshali-chitikeshi