Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Remove MessageBus Options data from configuration after client created #4016

Merged
merged 1 commit into from
May 10, 2022
Merged

fix: Remove MessageBus Options data from configuration after client created #4016

merged 1 commit into from
May 10, 2022

Conversation

lenny-goodell
Copy link
Member

fixes #4015

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

fix: Remove MessageBus Options data from configuration after client c…
583e9f9 
…reated

fixes edgexfoundry#4015

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenny-goodell lenny-goodell merged commit 1da0004 into edgexfoundry:main May 10, 2022
@lenny-goodell lenny-goodell deleted the remove-data-from-map branch May 10, 2022 18:58
@jba jba mentioned this pull request Jun 14, 2022
Open
@GoVulnBot GoVulnBot mentioned this pull request Jun 14, 2022
Closed
@jim-wang-intel jim-wang-intel mentioned this pull request Jul 11, 2022
Closed
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@bnevis-i bnevis-i Awaiting requested review from bnevis-i

@cloudxxx8 cloudxxx8 Awaiting requested review from cloudxxx8

@jpwhitemn jpwhitemn Awaiting requested review from jpwhitemn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need deep copy on MessageBus Optional config
2 participants
@lenny-goodell @jim-wang-intel