Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Schedule action record retention implementation #4966

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

jackchenjc
Copy link
Contributor

closes #4912

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat: Add support-cron-scheduler retention docs edgex-docs#1377

Testing Instructions

New Dependency Instructions (If applicable)

closes edgexfoundry#4912

Signed-off-by: Jack Chen <jack@iotechsys.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.75758% with 49 lines in your changes missing coverage. Please review.

Project coverage is 31.79%. Comparing base (a0e9b9b) to head (21ad77f).

Files with missing lines Patch % Lines
.../cronscheduler/application/scheduleactionrecord.go 32.35% 20 Missing and 3 partials ⚠️
...eduler/infrastructure/interfaces/mocks/DBClient.go 33.33% 5 Missing and 7 partials ⚠️
...kg/infrastructure/postgres/scheduleactionrecord.go 0.00% 7 Missing ⚠️
internal/support/cronscheduler/init.go 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4966   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files         265      265           
  Lines       19347    19413   +66     
=======================================
+ Hits         6151     6172   +21     
- Misses      11800    11831   +31     
- Partials     1396     1410   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jack Chen <jack@iotechsys.com>
Copy link

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 39873e1 into edgexfoundry:main Oct 14, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Action Record Retention Implementation
3 participants