Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarified conflicting rules in multiple sections defined in the same .editorconfig file when matched for single file #75

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

mipo256
Copy link
Member

@mipo256 mipo256 commented Mar 1, 2025

Solves #74


📚 Documentation preview 📚: https://editorconfig-specification--75.org.readthedocs.build/

@mipo256 mipo256 requested a review from xuhdev March 1, 2025 17:17
@mipo256 mipo256 added the clarification Improve text without changing its meaning label Mar 1, 2025
@mipo256 mipo256 requested a review from xuhdev March 3, 2025 19:23
@mipo256 mipo256 self-assigned this Mar 3, 2025
@mipo256
Copy link
Member Author

mipo256 commented Mar 3, 2025

Hey @xuhdev! can you please re-review? I doubt I've understood you correctly, so please check if everything is alright 😄

index.rst Outdated
Comment on lines 217 to 220
files take precedence. Thus, in case a given file matches multiple sections
within a single ``.editorconfig`` file, the pairs defined in the section that
comes later in the ``.editorconfig`` file take precedence over pairs defined
in the section that comes earlier in the same ``.editorconfig`` file.
Copy link
Member

@xuhdev xuhdev Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being unclear. I meant the addition can go after the first period of this paragraph ("...take
precedence."), because this addition talks about multiple sections within a single file, which is exactly elaborates what the first sentence says.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks!

@mipo256
Copy link
Member Author

mipo256 commented Mar 5, 2025

Hey @xuhdev! I've applied the fix, re-review please

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@xuhdev xuhdev merged commit 83c7ecb into editorconfig:master Mar 5, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
clarification Improve text without changing its meaning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants