Fix getFieldset
with interfaces and nullable schemas
#508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #499, specifically the types failing to reveal
getFieldset
in these two scenarios:FieldSchema
is an interface, not a type.defaultValue
is nullable.Known existing issues this PR doesn't try to fix:
getFieldset
is incorrectly available on other object types, e.g.Date
.I'm filing this as a draft, as I have no idea what kinds of tests to write for this.