Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Narrow the type prop returned from the getInputProps helper #579

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Narrow the type prop returned from the getInputProps helper #579

merged 1 commit into from
Apr 24, 2024

Conversation

AMEH64
Copy link
Contributor

@AMEH64 AMEH64 commented Apr 13, 2024

I updated the type annotations for the getInputProps helper function to better narrow the type prop that is returned.

Screenshot 2024-04-12 at 10 27 44 PM

This is the same change that was recently made to the getCollectionProps helper function.

@AMEH64 AMEH64 marked this pull request as ready for review April 13, 2024 02:53
edmundhung
edmundhung approved these changes Apr 16, 2024
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@edmundhung edmundhung force-pushed the feature/enhance-type-annotations branch from 0ee70cd to 91f3a86 Compare April 24, 2024 20:34
@edmundhung edmundhung merged commit 7a943f1 into edmundhung:main Apr 24, 2024
2 checks passed
@MattyBalaam
Copy link

Thanks @AMEH64 this was bugging us in our codebase.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMEH64 @MattyBalaam @edmundhung