Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Dart Sass deprecation warning - global built-in function str-leng… #233

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

posttoast
Copy link
Contributor

Fix Dart Sass deprecation warning - global built-in function str-length and str-slice are deprecated, changed to string.length and string.slice.

…th and str-slice are deprecated, changed to string.length and string.slice.
@jackmcpickle
Copy link
Collaborator

Thanks @posttoast , but you will need to change in the src too src/helpers/_trim.scss

@jackmcpickle
Copy link
Collaborator

Note I've just pushed a change to master to update the sass package and fix warnings in the tests. If you want to rebase

…th and str-slice are deprecated, changed to string.length and string.slice - updated source.
@posttoast
Copy link
Contributor Author

Thanks, I updated the pull request :)

@jackmcpickle
Copy link
Collaborator

Issue with the github node runner atm. npm/cli#7814 - but looks good will merge.

@jackmcpickle jackmcpickle merged commit e620564 into eduardoboucas:master Nov 6, 2024
0 of 3 checks passed
@jackmcpickle
Copy link
Collaborator

Thanks for picking up @posttoast

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants