Update reconnect logic

edumeet · Jun 7, 2023 · f87c557 · f87c557
1 parent 58b9d2c
commit f87c557
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/lib/BaseConnection.d.ts b/lib/BaseConnection.d.ts
@@ -6,7 +6,7 @@ export type InboundRequest = (request: SocketMessage, respond: (response: any) =
 export declare interface BaseConnection {
     on(event: 'close', listener: () => void): this;
     on(event: 'connect', listener: () => void): this;
-    on(event: 'reconnect', listener: (attempt: number) => void): this;
+    on(event: 'reconnect', listener: () => void): this;
     on(event: 'notification', listener: InboundNotification): this;
     on(event: 'request', listener: InboundRequest): this;
 }

diff --git a/lib/IOClientConnection.js b/lib/IOClientConnection.js
@@ -93,9 +93,12 @@ class IOClientConnection extends BaseConnection_1.BaseConnection {
             logger.debug('handleSocket() connected');
             this.emit('connect');
         });
-        this.socket.once('disconnect', () => {
+        this.socket.once('disconnect', (reason) => {
             logger.debug('socket disconnected');
-            this.close();
+            if (reason === 'io server disconnect')
+                this.close();
+            else
+                this.emit('reconnect');
         });
         this.socket.on('notification', (notification) => {
             logger.debug('"notification" event [notification: %o]', notification);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "edumeet-common",
-	"version": "0.5.1",
+	"version": "0.5.2",
 	"description": "Common code for edumeet",
 	"main": "lib/index.js",
 	"types": "lib/index.d.ts",

diff --git a/src/BaseConnection.ts b/src/BaseConnection.ts
@@ -18,7 +18,7 @@ export declare interface BaseConnection {
 	// Connection events
 	on(event: 'close', listener: () => void): this;
 	on(event: 'connect', listener: () => void): this;
-	on(event: 'reconnect', listener: (attempt: number) => void): this;
+	on(event: 'reconnect', listener: () => void): this;
 
 	// Inbound messages
 	on(

diff --git a/src/IOClientConnection.ts b/src/IOClientConnection.ts
@@ -118,10 +118,13 @@ export class IOClientConnection extends BaseConnection {
 			this.emit('connect');
 		});
 
-		this.socket.once('disconnect', () => {
+		this.socket.once('disconnect', (reason) => {
 			logger.debug('socket disconnected');
 
-			this.close();
+			if (reason === 'io server disconnect')
+				this.close();
+			else
+				this.emit('reconnect');
 		});
 
 		this.socket.on('notification', (notification) => {