-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
In-memory shading #39
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
62a8f69
Try to reproduce shapeless issue
eed3si9n 1785533
Fix file name encoding issue
eed3si9n 759f08e
Implement in-memory shading
eed3si9n 0bbc585
Remove zipping and unzipping code
eed3si9n 82421ab
Comma
eed3si9n d41bfc7
Address reviews
eed3si9n 0c2d4a0
Check the sha
eed3si9n c6017b4
Fix minimum timestamp
eed3si9n 7204aea
Stream to calculate sha-256
eed3si9n d368596
Use Files.move
eed3si9n 0604387
Drop Scala 2.10 and 2.11
eed3si9n 8e36912
Format
eed3si9n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ package testpkg | |
import verify._ | ||
import java.nio.file.{ Files, Path, Paths } | ||
import com.eed3si9n.jarjarabrams.{ Shader, Zip } | ||
import scala.sys.process.Process | ||
|
||
object ShaderTest extends BasicTestSuite { | ||
final val byteBuddyJar = "example/byte-buddy-agent.jar" | ||
|
@@ -15,7 +16,7 @@ object ShaderTest extends BasicTestSuite { | |
Paths.get(byteBuddyJar), | ||
resetTimestamp = false, | ||
expectedClass = expectedByteBuddyClass, | ||
expectedSha = "6e7372e52e3b2e981ffa42fc29d5cec1cc84431972d45fb51d605210e11c3ebd" | ||
expectedSha = "673a5b1d7282ec68def6d6e6845c29d96142e4e3b39796484e122cd92f65edee" | ||
) | ||
} | ||
|
||
|
@@ -65,6 +66,8 @@ object ShaderTest extends BasicTestSuite { | |
) | ||
val entries = Zip.list(tempJar).map(_._1) | ||
assert(entries.contains(expectedClass)) | ||
val lines = Process(s"unzip -l $tempJar").!!.linesIterator.toList.take(10) | ||
lines.foreach(println) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we remove now? |
||
val actualSha = Zip.sha256(tempJar) | ||
assert(actualSha == expectedSha) | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was off by 1000x (milisec).