fix: Carriage return in tag shorthand (#501)

eemeli · Nov 3, 2023 · 4af7419 · 4af7419
1 parent e8576e8
commit 4af7419
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/doc/directives.ts b/src/doc/directives.ts
@@ -143,7 +143,7 @@ export class Directives {
       return verbatim
     }
 
-    const [, handle, suffix] = source.match(/^(.*!)([^!]*)$/) as string[]
+    const [, handle, suffix] = source.match(/^(.*!)([^!]*)$/s) as string[]
     if (!suffix) onError(`The ${source} tag has no suffix`)
     const prefix = this.tags[handle]
     if (prefix) {

diff --git a/tests/doc/types.ts b/tests/doc/types.ts
@@ -112,6 +112,12 @@ describe('tags', () => {
       expect(doc.errors).toHaveLength(1)
       expect(doc.errors[0].message).toMatch('URIError')
     })
+
+    test('CR in tag shorthand (eemeli/yaml#501', () => {
+      const doc = parseDocument(': | !\r!')
+      const err = doc.errors.find(err => err.code === 'TAG_RESOLVE_FAILED')
+      expect(err).not.toBeFalsy()
+    })
   })
 
   test('eemeli/yaml#97', () => {