fix: Corner case failure in error pretty-printer

eemeli · Apr 24, 2023 · 984f578 · 984f578
1 parent 443e3aa
commit 984f578
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/errors.ts b/src/errors.ts
@@ -91,7 +91,7 @@ export const prettifyError =
       let count = 1
       const end = error.linePos[1]
       if (end && end.line === line && end.col > col) {
-        count = Math.min(end.col - col, 80 - ci)
+        count = Math.max(1, Math.min(end.col - col, 80 - ci))
       }
       const pointer = ' '.repeat(ci) + '^'.repeat(count)
       error.message += `:\n\n${lineStr}\n${pointer}\n`

diff --git a/tests/doc/errors.js b/tests/doc/errors.js
@@ -341,6 +341,12 @@ describe('pretty errors', () => {
     const doc = YAML.parseDocument(src, { prettyErrors: true })
     expect(doc.warnings).toMatchObject([{ name: 'YAMLWarning' }])
   })
+
+  test('repeated CR', () => {
+    const src = '[' + '\r'.repeat(80)
+    const doc = YAML.parseDocument(src, { prettyErrors: true })
+    expect(doc.errors[0]).not.toHaveProperty('source')
+  })
 })
 
 describe('tags on invalid nodes', () => {