Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor Node range as [start, value-end, node-end] #259

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Conversation

eemeli
Copy link
Owner

@eemeli eemeli commented Apr 17, 2021

Fixes #258 by adding a third value to the range tuple.

For block values, value-end and node-end are always the same as the previous end value. For flow collections and documents, node-end is the same as the previous end position, while value-end marks the end of the actual value.

@gorkem, would this work for your use case?

@eemeli eemeli added the enhancement New feature or request label Apr 17, 2021
@eemeli
Copy link
Owner Author

eemeli commented Apr 17, 2021

Merging, as otherwise work on error ranges gets really clumsy.

@eemeli eemeli merged commit 16d01cc into master Apr 17, 2021
@eemeli eemeli deleted the extend-range branch April 17, 2021 18:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In correct range
1 participant