Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added type for Form collector and use it in compiled template #115

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Added type for Form collector and use it in compiled template #115

merged 1 commit into from
Dec 6, 2022

Conversation

lulco
Copy link
Contributor

@lulco lulco commented Dec 6, 2022

Resolves #101

This was referenced Dec 6, 2022
Open
Closed
@MartinMystikJonas
Copy link
Collaborator

Could resulting type be UnionType? It is probaly edge case but should he coveret to be sure to not generate invalid php.

@MartinMystikJonas
Copy link
Collaborator

Or maybe all cases when it is not ObjectType (could be mixed with missing type hint)

@lulco
Copy link
Contributor Author

lulco commented Dec 6, 2022

At the moment it will not pass through this condition:

$returnType->isInstanceOf('Nette\Forms\Form')->yes()

But yes, in theory it can be any type

@lulco lulco merged commit a182d8e into main Dec 6, 2022
@lulco lulco deleted the collect-form-type branch December 6, 2022 16:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MartinMystikJonas MartinMystikJonas MartinMystikJonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom formRender and false positive errors such as renderPair
2 participants
@lulco @MartinMystikJonas