Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for Azurite object storage #70

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add support for Azurite object storage #70

merged 2 commits into from
Apr 18, 2024

Conversation

saswatamcode
Copy link
Collaborator

Adds Azurite blob storage and Azure cli runnable to e2edb.
Useful for e2e tests involving Azure objstore.

Can use it with objstore config like,

type: AZURE
config:
  storage_account: devstoreaccount1
  storage_connection_string: "DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://127.0.0.1:10000/devstoreaccount1;"
  container: bkt1
  endpoint: 0.0.0.0:10000

TODO: Actually write tests with it.

@saswatamcode
Add support for Azurite object storage
8ecfa78 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@saswatamcode
Fix lint
b22b205 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
bwplotka approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saswatamcode
Copy link
Collaborator Author

Thanks, merging!

@saswatamcode saswatamcode merged commit 97db25a into efficientgo:main Apr 18, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saswatamcode @bwplotka