Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Slugify function #120

Closed
codejockie opened this issue Oct 15, 2017 · 5 comments
Closed

Slugify function #120

codejockie opened this issue Oct 15, 2017 · 5 comments

Comments

@codejockie
Copy link
Contributor

Hi, @kentcdodds I saw your course on contributing to open source, so I took a dive in.
I would like to add the slugify function from this answer https://stackoverflow.com/questions/1053902/how-to-convert-a-title-to-a-url-slug-in-jquery

@kentcdodds
Copy link
Member

Sounds great!

@codejockie
Copy link
Contributor Author

Hi @kentcdodds I wrote a test for the function and running it throws this error:

1. slugify › slugifies a text
   failed with "(0 , _src.slugify) is not a function"
      Test.fn (slugify.test.js:7:18)
    _combinedTickCallback (internal/process/next_tick.js:73:7)
    process._tickCallback (internal/process/next_tick.js:104:9)

Any idea on this?

@kentcdodds
Copy link
Member

Yeah, make sure that you're importing and exporting it the same way the others do in src/index.js 😀

@codejockie
Copy link
Contributor Author

Thank you.

@codejockie
Copy link
Contributor Author

I'm done with the feature. I ran npm run commit and I get this Denote the scope of this change ($location, $browser, $compile, etc.):. What do I put there?

codejockie added a commit to codejockie/stack-overflow-copy-paste that referenced this issue Oct 15, 2017
A function to slugify text input, trims whitespaces and multiple dashes

Closes eggheadio-github#120
kentcdodds pushed a commit that referenced this issue Oct 15, 2017
A function to slugify text input, trims whitespaces and multiple dashes

Closes #120
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants