Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Add isArray to check if an object is a javascript array #38

Closed
rheaditi opened this issue Sep 9, 2016 · 2 comments
Closed

Add isArray to check if an object is a javascript array #38

rheaditi opened this issue Sep 9, 2016 · 2 comments

Comments

@rheaditi
Copy link
Contributor

rheaditi commented Sep 9, 2016

Hi 😇

I'd like to add an isArray( someObject) method that returns true/false based on whether the object someObject is a javascript array.

From this answer :)
Also, based on this polyfill.

Thanks

  • first timer
@kentcdodds
Copy link
Member

Awesome! Note, in the Contributing guidelines:

In the case of adding a new function, that function must:

  • NOT add anything to the prototype of built-in objects (one of StackOverflow's favorite things to do)

So, you can still implement this function, you'll just need to adjust it so it doesn't modify Array

Thanks! Looking forward to seeing your pull request! Let me know if you need any help 😄

kentcdodds pushed a commit that referenced this issue Sep 12, 2016
Added a method `isArray` to check if an object passed as a parameter is
a javascript array.

Includes 6 tests and 100% coverage.
@kentcdodds
Copy link
Member

This was resolved a while back :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants