Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

WIP: subtract two number #106

Merged
merged 4 commits into from
Jul 25, 2017
Merged

WIP: subtract two number #106

merged 4 commits into from
Jul 25, 2017

Conversation

jsina
Copy link
Contributor

@jsina jsina commented Jul 19, 2017

subtraction method for subtracting two number. the type of return data from this method is integer.

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     37           
  Lines         106    106           
=====================================
  Hits          106    106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7621e...f26aec4. Read the comment docs.

@kentcdodds
Copy link
Member

Looking good! Just need to make changes to index.js and add a test file here 😄

@kentcdodds
Copy link
Member

I noticed that you added the test file in another pull request. Could you update this pull request to have all the changes necessary?

@jsina
Copy link
Contributor Author

jsina commented Jul 25, 2017

@kentcdodds there is no "npm run cover | npm run build' on travis.yml file. there is just 'npm prune' file under script title on that file

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the other implementations, you'll see that they also change the src/index.js file. Could you do the same for this one?

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks!

@kentcdodds kentcdodds merged commit 10eb532 into eggheadio-github:master Jul 25, 2017
@jsina jsina deleted the imp1 branch July 29, 2017 14:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants