This repository was archived by the owner on Feb 20, 2019. It is now read-only.
feat(isNumeric): add isNumeric function #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 39 40 +1
Lines 108 109 +1
=====================================
+ Hits 108 109 +1
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Aug 7, 2017
src/index.js
Outdated
|
|
||
| export { | ||
| isOdd, |
There was a problem hiding this comment.
Could you fix the indentation here to just be 2 spaces for every line?
There was a problem hiding this comment.
it should be ok now , right ?
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add isNumeric function that return true if an expression can be evaluated as a number and false if not