feat(max): Add max function (#114) #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 41 +1
Lines 109 113 +4
=====================================
+ Hits 109 113 +4
Continue to review full report at Codecov.
|
test/max.test.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| import test from 'ava' | |||
| import max from '../src/max' | |||
There was a problem hiding this comment.
This should be: import {max} from '../src' (see the other tests).
This means that you'll need to import max into the src/index.js and add it to the list of exports. Could you do that update please?
the max function could find the maximum value of the list Closes eggheadio-github#114
|
I don't know why I get the error after I revise the test |
|
Go ahead and push what you have and I can help 👍 |
|
I already push the project as the same commit. please review the commit 31c9877 |
| @@ -0,0 +1,8 @@ | |||
| import test from 'ava' | |||
| import {max} from '../src' | |||
There was a problem hiding this comment.
Ah, the reason you're having this problem is because you haven't added the import/export to src/index.js yet. :)
There was a problem hiding this comment.
Oh! Got it! I done XD
Does import file by this way could have better performance? :)
There was a problem hiding this comment.
No, but it makes it easier for folks to use this package:
import {max} from 'stack-overflow-copy-paste'Even though nobody should really be using this package 😉 It's just for folks to practice contributing to OSS!
|
Thanks so much! You did great! 👏 |
the max function could find the maximum value of the list
Please review the implementation
Thanks :)
Closes #114