Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

feat(largest): finds largest number in an array #229

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

AkashRajpurohit
Copy link
Contributor

Most of the changes in src/index.js is due to prettier configuration of my vscode.
everything else is cool!

@codecov-io
Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #229   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          88     89    +1     
  Lines         394    397    +3     
=====================================
+ Hits          394    397    +3
Impacted Files Coverage Δ
src/largest.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5d379...c489ff9. Read the comment docs.

@AkashRajpurohit
Copy link
Contributor Author

Cool it passed.
Thanks for the suggestion about running the travis-ci script npm run validate locally to test before commiting. Will keep a habit for doing that in upcoming open source contributions as well. Cheers

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@kentcdodds kentcdodds merged commit 25bd8a5 into eggheadio-github:master Feb 2, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants