Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

feat(getTriangleType): get type of a Triangle #252

Merged
merged 1 commit into from
Feb 18, 2019
Merged

feat(getTriangleType): get type of a Triangle #252

merged 1 commit into from
Feb 18, 2019

Conversation

bolah2009
Copy link
Contributor

Added a function that gets the name of a triangle. The input is the three sides of the triangle and the output (return a String) is the corresponding triangle name (Equilateral, Isosceles and Scalene).

@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     96    +1     
  Lines         465    466    +1     
=====================================
+ Hits          465    466    +1
Impacted Files Coverage Δ
src/getTriangleType.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ee1a3...4fb4d01. Read the comment docs.

@bolah2009
Copy link
Contributor Author

bolah2009 commented Feb 17, 2019

Hi @kentcdodds, this is my first PR. After going through your Egghead.io series entitled: How to Contribute to an Open Source Project on GitHub am glad to push my first PR! Thanks! All checks have passed

@kentcdodds kentcdodds merged commit 8b80d3c into eggheadio-github:master Feb 18, 2019
@kentcdodds
Copy link
Member

Great job!

@bolah2009
Copy link
Contributor Author

Thanks for accepting the request!!!

@bolah2009 bolah2009 deleted the pr/getTriangleType branch February 19, 2019 10:50
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants