feat: supports retrieving the port from the configuration file (#250) #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the no-veronica Team on Vercel. A member of the Team first needs to authorize it. |
|
see issue #250 |
|
@JarryChung 单测没通过，需要看看 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 95 95
Branches 19 19
=========================================
Hits 95 95 ☔ View full report in Codecov by Sentry. |
|
@fengmk2 我关注到单测的 demo-app 不是一个标准的 egg 应用，会导致获取配置文件失败，因此我将获取配置文件的逻辑放在 try...catch... 中了，当获取失败时，使用原来的的逻辑。这个处理方式应该要健壮一些，可以避免外部依赖带来的影响。 |
fengmk2
pushed a commit
that referenced
this pull request
Feb 1, 2024
[skip ci] ## [6.8.0](v6.7.0...v6.8.0) (2024-02-01) ### Features * supports retrieving the port from the configuration file ([#251](#251)) ([07e150f](07e150f))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Adjust the order in which ports are obtained：option
--port> egg.js configurationconfig/config.*.js>process.env.EGG_BIN_DEFAULT_PORT> 7001 > other available ports.closes #250