Option sourcemap: 'inline' not working

[fox1t]

Hi!
As per documentation it should be possible to pass inline as sourcemap option. In reality, passing it is treated the same as passing any other value thanks to this line: https://github.com/egoist/tsup/blob/dev/src/esbuild/index.ts#L134

Moreover, the relative test is wrong too and doesn't catch this error. We can see that it is checking for the presence of
at https://github.com/egoist/tsup/blob/dev/test/index.test.ts#L188 instead of the more safe //# sourceMappingURL=data:

I've already had a fix, and I can open a PR, but there is just one last thing that bothers me. esbuild documentation says that external shouldn't add //# sourceMappingURL= at the end of the file, but running this test and checking the output, shows a different story. Any clues?

And this is why the inline test is passing even if the option is not working at the moment.

...
PERFORMANCE OF THIS SOFTWARE.
***************************************************************************** */
//# sourceMappingURL=input.js.map

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[egoist]

inline sourcemap was removed and the docs should be updated, any specific reason you need inline sourcemap?

[fox1t]

I am developing a custom tsup configuration that takes some paramters that tsup care about directly from the tsconfig.json.
In particular:

• entry is mapped to tsConfig.fileNames
• outDir is tsConfig.outDir
• sourcemap: is either tsConfig.sourcemap or tsConfig.inlineSourceMap
• target is tsConfig.compilerOptions.target

Should we remove the inline option test too?
Out of curiosity, why it was removed?

[egoist]

just did a bit research, there're indeed use cases for inline sourcemap (like developing browser extensions), we should bring it back, but it should be added in

tsup/src/plugin.ts

Lines 160 to 174 in d428ce7

	await outputFile(
	info.path,
	info.type === 'chunk'
	? info.code + getSourcemapComment(!!info.map, info.path, isCSS(file.path))
	: info.contents,
	{ mode: info.type === 'chunk' ? info.mode : undefined }
	)
	if (info.type === 'chunk' && info.map) {
	const map =
	typeof info.map === 'string' ? JSON.parse(info.map) : info.map
	// map.sources = map.sources?.map((name: string) =>
	// path.relative(path.dirname(info.path), name)
	// )
	await outputFile(`${info.path}.map`, JSON.stringify(map))
	}

, currently we perform some extra operations on the sourcemap output by esbuild and manually write it to disk

[github-actions]

🎉 This issue has been resolved in version 5.11.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀