Add typescript definition file #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vue-content-loader ready! Built with commit 510678d |
|
|
egoist
reviewed
Oct 16, 2018
| @@ -7,6 +7,7 @@ | |||
| "type": "git" | |||
| }, | |||
| "main": "dist/vue-content-loader.cjs.js", | |||
| "types": "src/vue-content-loader.d.ts", | |||
There was a problem hiding this comment.
maybe move to index.d.ts? src folder is not published on npm.
eriestrisnadi
approved these changes
Jan 15, 2021
|
Closing in favor of #121 |
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this library for a personal app and I needed a typescript definition file so here it is!
Since it's a small code base and there is not much properties going on, every vue properties are declared for
ContentLoaderand the other definitions are just extendingContentLoaderConstructor.Already tested on my local source code, need to be tested before merged though (first time I'm doing a .d.ts file for a particular module).
Should solve #11