Skip to content

Include input parameters in ReturnContractError #215

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
beezee opened this issue Jan 9, 2016 · 2 comments
Open

Include input parameters in ReturnContractError #215

beezee opened this issue Jan 9, 2016 · 2 comments

Comments

@beezee
Copy link
Contributor

beezee commented Jan 9, 2016

Because these are runtime, I think it's way more useful to see what input produced an invalid return, considering it doesn't necessarily mean you have this error on all possible inputs.

Is this something folks agree with, or are there concerns about it?

If it would be accepted (barring any code review of course) I would be happy to open a PR
@egonSchiele
Copy link
Owner

Sounds good to me, send over a PR!

@alex-fedorov
Copy link
Collaborator

👍 Sounds good to me too!

Best Regards,
Oleksii Fedorov,
Sr Ruby, Clojure, Crystal, Golang Developer,
Microservices Backend Engineer,
+49 15757 486 476

On Sat, Jan 9, 2016 at 7:06 AM, Aditya Bhargava notifications@github.com
wrote:

Sounds good to me, send over a PR!

—
Reply to this email directly or view it on GitHub
#215 (comment)
.

egonSchiele added a commit that referenced this issue Mar 8, 2016
@egonSchiele
Issue #215: ContractError should also show the arguments that caused …
c7d5910 
…the error
@egonSchiele egonSchiele mentioned this issue Mar 8, 2016
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@egonSchiele @beezee @alex-fedorov