Make KeywordArgs fail if unexpected keys are passed in #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm weird, specs passed with 2.2 on my machine. I'll look into the failures. |
|
Ah |
abevoelker
force-pushed
the
keywordargs_unexpected_keys
branch
from
61f67c9 to
31e2066
Compare
|
Looks like you actually want to fix this spec. Because it tries to pass in unexpected argument and expects it to not fail. Seems like a buggy behavior to me. |
|
Okay I think I fixed it - let me know if I violated the intent of the spec or whatnot |
| options.all? do |key, contract| | ||
| Optional._valid?(hash, key, contract) | ||
| end | ||
| (hash.keys - options.keys == []) && |
There was a problem hiding this comment.
Can you use guard statement here instead - current code makes it hard to read. Example:
def valid?(hash)
return false unless hash.keys - options.keys == [] # <--- this is a guard statement
# .. do the main job here ..
endThere was a problem hiding this comment.
Oh yeah for sure, should've asked about that
|
Other than that, looks good. |
abevoelker
force-pushed
the
keywordargs_unexpected_keys
branch
from
31e2066 to
1960743
Compare
|
@abevoelker Thanks! |
alex-fedorov
added a commit
that referenced
this pull request
Jul 23, 2015
Make KeywordArgs fail if unexpected keys are passed in
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure where to put the KeywordArgs specs - let me know if it should go in spec/contracts_spec.rb or whatnot (or if I'm otherwise way off base)