Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Amendments from discussion on 01/26 #9

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Amendments from discussion on 01/26 #9

merged 1 commit into from
Feb 10, 2023

Conversation

Ryun1
Copy link

@Ryun1 Ryun1 commented Jan 27, 2023 •
edited
Loading

Changes:

  • Changed Proposal optional fields and added a boolean flag.
    • This better defines the difference between proposals supplied to private/public votes.
  • Added in InvalidProposalError for incorrect use of boolean flag.
    • To match the above.
  • Changed voteOptions in Vote to a number.
    • It was accidently changed to an array a few commits back.
  • Added default value for spendingCounter to Vote.
    • This was missing.
  • Renamed GovernanceKey to WeightedKey.
    • Better alignment with naming used in CIP-36.
    • Changed votingKey to voteKey
  • Some general prose improvements.
    • Better alignment with naming used in CIP-36.
  • Changed votingKey to voteKey in votingCredentials.
  • Removed spendingCounter, spendingCounterLane and expiration from Proposal.
    • Because these are no longer needed.
  • Removed supporting artefacts, like BlockDate and BlockDateError.
    • I replaced BlockDateError with the new InvalidProposalError here, so that InvalidProposalError has BlockDateError's errorcode of -103.
  • Added some prose around Proposal.

@Ryun1 Ryun1 force-pushed the cip-62-update-01-27 branch from 3ed292a to cd01686 Compare February 6, 2023 12:45
@Ryun1 Ryun1 force-pushed the cip-62-update-01-27 branch from 110ee74 to 04edd0c Compare February 9, 2023 12:24
ehanoc
ehanoc approved these changes Feb 10, 2023
View reviewed changes
Copy link
Owner

@ehanoc ehanoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehanoc ehanoc merged commit 3db6476 into ehanoc:cip-governance-wallet-connector Feb 10, 2023
Ryun1 referenced this pull request in Ryun1/CIPs Aug 3, 2023
@michael-liesenfelt @ccgarant
@KtorZ @rphair
CIP-0050? | Pledge Leverage-Based Staking Rewards (cardano-foundation…
827e054 
…#242)

* Create test.txt

* Add files via upload

* Delete test.txt

* Update README.md

* Update README.md

Fixing minor mistakes, chart references, and chart descriptions.

* Add files via upload

* Update README.md

Reordered the dangers of increasing k section.
Added an a0 = 10.0 chart.
Cleaned up some formatting.
Updated CIP number in the header.

* Create README.Spanish.md

* Update README.md

Corrected errors, added descriptions, and changed the implementation path.

* Add files via upload

Updated versions.

* Add files via upload

* Delete k-effective.png

* Add files via upload

* Update README.md

Added Christina Ovezik to the reviewers list.

* Update README.md

Only added a couple more reviewers.

* Update README.Spanish.md

Translation in Spanish by: Juan Montano, DOT5 SPO
Traducido en Español por: Juan Montano, DOT5 SPO

* Create README.Chinese.md

* Add files via upload

* fancy markdown equation updates

* markdown equation updates
* equations updates to match master
Co-authored-by: ccgarant <>

* Update README.md

Labeled the pledge leverage factor L, instead of renaming a0.
Updated large stakeholder section slightly, but did not include detailed ROIC charts yet.
Included Oversaturation Attack (OA) description/mitigation.
Added equation variations in Rationale as recommended by CIP-1 guidance.
Left a stub for recommended pool ranking based on leverage, however an official ranking standard could be an independent CIP.
I haven't updated all the charts and labels yet, but that will happen soon.
Also, thanks to Christophe for his contributions and looking forward to many more!

* Add files via upload

Updated k-effective chart and k-effective table.

* definitions and concepts added (#8)

* Equations Reverted to Images for Mobile Readability (#9)

* equ 1 and 2 updated, new branch made

* more equations added

* test center image alignment

* centering and resizing remaining figures

* resized figures and minor edits

* Updates

Minor updates and corrections.
Added short description for the ranking paradigm.
Added CIP-7 equation into the list.
I still have to update all the graphics (a0 to L, % yield to % R)

* Added updated charts

* Update README.md

Updated the charts.

* Add files via upload

* recommended leverage-based pool ordering system (#10)

* recommended pool ordering system added

* comments round 1 incorporated

* added saturation_factor and some cleanup

* added pool-ranking-analysis spreadsheet

* removed grading to be objective, and simplified.

* Update README.md

Added equation variation. Incomplete equation rendering.

* Alternate equation additions, CIP-7, Nimer addition (#11)

* cip-7-additions

* added nimer ada link equ, moved all images folder

* nimer equation section update

* Update README.md

Removed small pool advantage section.
Minor updates and revisions.
Consolidated parameter sets.

* Rename folder as CIP-0050

* Format CIP-0050 according to CIP-0001

  Slightly re-ordered some sections around, and applied a bit of styling / cosmethic.

* update title for specificity

* Update README.md

Updated Conflict of Interest statement and also the PR description.

ToDo: Update all the figures with current values and content from Balance Analytics.

---------

Co-authored-by: Christophe Garant <ccgarant@gmail.com>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Ryun1 referenced this pull request in Ryun1/CIPs Nov 17, 2023
@michael-liesenfelt @ccgarant
@KtorZ @rphair
CIP-0050? | Pledge Leverage-Based Staking Rewards (cardano-foundation…
462f29d 
…#242)

* Create test.txt

* Add files via upload

* Delete test.txt

* Update README.md

* Update README.md

Fixing minor mistakes, chart references, and chart descriptions.

* Add files via upload

* Update README.md

Reordered the dangers of increasing k section.
Added an a0 = 10.0 chart.
Cleaned up some formatting.
Updated CIP number in the header.

* Create README.Spanish.md

* Update README.md

Corrected errors, added descriptions, and changed the implementation path.

* Add files via upload

Updated versions.

* Add files via upload

* Delete k-effective.png

* Add files via upload

* Update README.md

Added Christina Ovezik to the reviewers list.

* Update README.md

Only added a couple more reviewers.

* Update README.Spanish.md

Translation in Spanish by: Juan Montano, DOT5 SPO
Traducido en Español por: Juan Montano, DOT5 SPO

* Create README.Chinese.md

* Add files via upload

* fancy markdown equation updates

* markdown equation updates
* equations updates to match master
Co-authored-by: ccgarant <>

* Update README.md

Labeled the pledge leverage factor L, instead of renaming a0.
Updated large stakeholder section slightly, but did not include detailed ROIC charts yet.
Included Oversaturation Attack (OA) description/mitigation.
Added equation variations in Rationale as recommended by CIP-1 guidance.
Left a stub for recommended pool ranking based on leverage, however an official ranking standard could be an independent CIP.
I haven't updated all the charts and labels yet, but that will happen soon.
Also, thanks to Christophe for his contributions and looking forward to many more!

* Add files via upload

Updated k-effective chart and k-effective table.

* definitions and concepts added (#8)

* Equations Reverted to Images for Mobile Readability (#9)

* equ 1 and 2 updated, new branch made

* more equations added

* test center image alignment

* centering and resizing remaining figures

* resized figures and minor edits

* Updates

Minor updates and corrections.
Added short description for the ranking paradigm.
Added CIP-7 equation into the list.
I still have to update all the graphics (a0 to L, % yield to % R)

* Added updated charts

* Update README.md

Updated the charts.

* Add files via upload

* recommended leverage-based pool ordering system (#10)

* recommended pool ordering system added

* comments round 1 incorporated

* added saturation_factor and some cleanup

* added pool-ranking-analysis spreadsheet

* removed grading to be objective, and simplified.

* Update README.md

Added equation variation. Incomplete equation rendering.

* Alternate equation additions, CIP-7, Nimer addition (#11)

* cip-7-additions

* added nimer ada link equ, moved all images folder

* nimer equation section update

* Update README.md

Removed small pool advantage section.
Minor updates and revisions.
Consolidated parameter sets.

* Rename folder as CIP-0050

* Format CIP-0050 according to CIP-0001

  Slightly re-ordered some sections around, and applied a bit of styling / cosmethic.

* update title for specificity

* Update README.md

Updated Conflict of Interest statement and also the PR description.

ToDo: Update all the figures with current values and content from Balance Analytics.

---------

Co-authored-by: Christophe Garant <ccgarant@gmail.com>
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ehanoc ehanoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryun1 @ehanoc