Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding google tracking code for ehcache.org #84

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

akomakom
Copy link
Contributor

@akomakom akomakom commented Aug 8, 2016

No description provided.

@ljacomet ljacomet merged commit 9ac74d0 into ehcache:master Aug 9, 2016
@mathieucarbou
Copy link
Member

mathieucarbou commented Aug 9, 2016

@ljacomet : I wonder if the PR is complete because analytics should be activated only on ehcache.org, and not locally when testing the website. For that there are several options:

  1. JS code to conditionnaly init the tracker only if the document.location contains ehcache.org
  2. Templating code to test if the generation is done locally or on server (env var perhaps?)
  3. I know that in google analytics, we can filter out some origins (that is what I already did since all the dev team was accessing from the same static IP.). I don't know if we can filter out based on the URL (i.e. exclude localhost:4000/*)

@akomakom
Copy link
Contributor Author

akomakom commented Aug 9, 2016

If the local testing is done via jekyll, we can have a boolean variable that's only set for production. (Meaning a variable passed to jekyll on the command line)
Specifically JEKYLL_ENV :)
I'll make a PR for that

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants