Feature/cdr 1198 query response meta props #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlehn
force-pushed
the
feature/CDR-1198-query-response-meta-debug-props
branch
from
db5932e to
e68fdd6
Compare
alexlehn
force-pushed
the
feature/CDR-1198-query-response-meta-debug-props
branch
3 times, most recently
from
bf6e70c to
aad104b
Compare
alexlehn
force-pushed
the
feature/CDR-1198-query-response-meta-debug-props
branch
from
9bc5511 to
c168198
Compare
alexlehn
changed the title
alexlehn
requested review from
stefanspiska
and removed request for
vmueller-vg
alexlehn
force-pushed
the
feature/CDR-1198-query-response-meta-debug-props
branch
2 times, most recently
from
a22dd61 to
8a2e7be
Compare
stefanspiska
requested changes
Jan 19, 2024
| * Not part of the standard spec, but returned by openEHR since version <code>1.0.0</code> for debugging purposes. | ||
| * </pre> | ||
| */ | ||
| LongProperty fetch = () -> "fetch"; |
There was a problem hiding this comment.
If fetch is long than so would resultSize
There was a problem hiding this comment.
I think both could be int
There was a problem hiding this comment.
you are right, integer seems to be sufficient.
stefanspiska
approved these changes
Jan 19, 2024
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.6.2 to 3.6.3. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.6.2...maven-javadoc-plugin-3.6.3) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
alexlehn
force-pushed
the
feature/CDR-1198-query-response-meta-debug-props
branch
from
3586c92 to
3be5a06
Compare
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extend the
QueryResponseData.metaresponse object to map also the additionalfetch,offsetamdresultsizeproperties, that are supported byEHRBase 1.0.0. Further more addelimitandoffsetto the ehrscapeQueryResultDtoto be able to pass such informations in EHRBase.Now a
MetaDataobject can be constructed fromQueryResponseDatathat contains all basic properties.Additional information
QueryResponseDataandMetaDataDTOs.palantirJavaFormatto2.24.0to be able to use spotless with Java 21Pre-Merge checklist