Fixed issue with logs where message contains semicolon #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages that contains a semicolon are not replaced correctly. For example:
console.log("Ok;");or
console.log(["Test", "Ok"].map(function(s){return s;}));I've added two unit tests that are failing with the current code.
This PR updates the Regex inner expression to detect the log message from:
\([^;]*\)to
\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*\)The new expression is based on matching nested brackets. Note that this will only work up to two levels of nesting. To add levels, you could change the middle (second) [^()]* part to ([^()]|([^()]))*, but I believe supporting two levels should be sufficient for most cases.