Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Css fixes #219

Merged
Merged

Conversation

Christoffer-Cortes
Copy link
Contributor

@Christoffer-Cortes Christoffer-Cortes commented Jul 2, 2019

Applicable Issues

Description of the Change

Some adjustments to the CSS.

  • Dropdown menu arrows have fixed width so that they no longer change width when clicked.
  • Header dropdown menu item text is now highlighted.
  • All items in header now have min-width set.
  • Notification and Login/Username are hidden in small views.
  • Notification and Login/Username now has a fixed width. Looks ok in large views but a little strange in smaller views especially when ldap is disabled. This is to avoid strange pushed/misaligned elements in smaller views since username can vary in size.
  • Update images in documentation

If someone knows of a better way for an element to take up the max width of its content that works on IE, Firefox and Chrome I'd welcome the feedback.

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Christoffer Cortes Sjöwall, christoffer.cortes.sjowall@ericsson.com

Copy link
Member

@e-pettersson-ericsson e-pettersson-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Christoffer-Cortes Christoffer-Cortes merged commit 15a02b9 into eiffel-community:master Jul 2, 2019
@Christoffer-Cortes Christoffer-Cortes deleted the CssFixes branch September 2, 2019 07:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants