Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Standardize error message handling #221

Merged

Conversation

Christoffer-Cortes
Copy link
Contributor

Applicable Issues

Description of the Change

An attempt to standardize error response.

  • Error logging now has another method that takes the message value of a response.
  • If an error callback is not defined the default is to try to print the message value.

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Christoffer Cortes Sjöwall, christoffer.cortes.sjowall@ericsson.com

@Christoffer-Cortes Christoffer-Cortes changed the title Error messages Standardize error message handling Jul 4, 2019
Copy link
Contributor

@tobiasake tobiasake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a question/comment about earlier issues with JSON in Ajax responses in some web-browsers.

src/main/resources/static/js/#.js Outdated Show resolved Hide resolved
src/main/resources/static/js/subscription.js Outdated Show resolved Hide resolved
src/main/resources/static/js/subscription.js Outdated Show resolved Hide resolved
src/main/resources/static/js/testrules.js Outdated Show resolved Hide resolved
@Christoffer-Cortes Christoffer-Cortes merged commit 0f0e16a into eiffel-community:master Jul 8, 2019
@Christoffer-Cortes Christoffer-Cortes deleted the ErrorMessages branch September 2, 2019 07:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants