ETR to wait for environment #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
t-persson
force-pushed
the
fix-timeout-add-timeout-add-type-hints
branch
from
63b72e0 to
c5ec806
Compare
t-persson
commented
Jan 16, 2025
Comment on lines
-177
to
+158
| return None | ||
| continue |
There was a problem hiding this comment.
For clarity: This is the fix, the rest is type-hints and cleanup.
andmat900
approved these changes
Jan 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
The timeout has never really worked in the ETR since we returned when a failure was encountered. This fix allows the retry to actually work.
I also added type-hints and removed an unnecessary parse_args function.
Alternate Designs
I wanted the timeout to be easily configurable and I really wanted it to be longer to allow the ETR to start and wait for environments before the environment provider has finished, but adding more configuration options to ETOS when we don't already control what we have (eiffel-community/etos#304) felt wrong so I decided to lean on the default wait timeout instead.
Possible Drawbacks
We will now take longer to fail should the environment not exist, but that's nothing I'm worried about.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com