Remove dep for lxml in favor of stdlib HTMLParser #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the travis run (usually with it enabled on the repository it'll show up for PRs): https://travis-ci.org/asottile/nodeenv/builds/47159091 |
ekalinin
added a commit
that referenced
this pull request
Jan 16, 2015
Remove dep for lxml in favor of stdlib HTMLParser
|
🔥 |
|
<3 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues in http://github.com/pre-commit/pre-commit-hooks with installing lxml under pypy3. Also given that lxml is pretty heavy-weight and no deps >>> having deps I decided to factor lxml out of nodeenv.
I also added a testsuite and made it work with travis-ci... hope that's ok :)