Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Download musl-compatible nodeenv from unofficial-builds #247

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Download musl-compatible nodeenv from unofficial-builds #247

merged 2 commits into from
Feb 10, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jan 1, 2020

Resolves #204

I needed to change the strategy of downloads due to unofficial-builds.nodejs.org having a slightly different structure -- fortunately, all three of iojs.org / nodejs.org and unofficial-builds.nodejs.org all have the new structure 🎉

I tested this by mounting nodeenv.py into an alpine docker image, after installing libstdc++ I was able to download and utilize a prebuilt nodeenv:

(venv) bash-5.0# nodeenv /nenv -vvv
 * Install prebuilt node (13.5.0) ..... done.
(venv) bash-5.0# . /nenv/bin/activate
(nenv) (venv) bash-5.0# apk add libstdc++
(1/2) Installing libgcc (9.2.0-r3)
(2/2) Installing libstdc++ (9.2.0-r3)
OK: 96 MiB in 36 packages
(nenv) (venv) bash-5.0# node --version
v13.5.0

@asottile
Copy link
Contributor Author

asottile commented Feb 7, 2020

@ekalinin would appreciate a review on this one too! this fixes nodeenv to not use the deprecated structure and enables nodeenv to work out of the box on alpine / other muslc-based images

@ekalinin
Copy link
Owner

@asottile thanks for the patch and sorry for delay.

@ekalinin ekalinin merged commit 079fcf5 into ekalinin:master Feb 10, 2020
@asottile asottile deleted the muslc branch February 10, 2020 15:46
@asottile
Copy link
Contributor Author

🎉 thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeenv --prebuilt on musl libc produces non-working binaries
2 participants