Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to PHPStan 2.x #69

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Upgrade to PHPStan 2.x #69

merged 1 commit into from
Nov 13, 2024

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Nov 11, 2024

PHPStan 2.x has just been released.

This PR upgrade the code to allow usage of this new major version.

Copy link
Member

@mremi mremi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jdecool thank you for this contribution, could you please check my comments and update CHANGELOG.md?

src/Rules/BannedNodesErrorBuilder.php Show resolved Hide resolved
tests/Rules/BannedNodesRuleTest.php Show resolved Hide resolved
@vlaurier
Copy link
Contributor

@jdecool @mremi
I was working on it today and didn't see this pull request. My bad.
But maybe, you/we can pick some elements from the one I have just opened. #70
And you can of course close mine.

@mremi
Copy link
Member

mremi commented Nov 13, 2024

@jdecool @mremi I was working on it today and didn't see this pull request. My bad. But maybe, you/we can pick some elements from the one I have just opened. #70 And you can of course close mine.

Hi @vlaurier this one came first :) so I'll accept it, anyway thank you for your contribution 👍

src/Rules/BannedNodesErrorBuilder.php Outdated Show resolved Hide resolved
@mremi mremi merged commit d174a03 into ekino:master Nov 13, 2024
3 checks passed
@mremi
Copy link
Member

mremi commented Nov 13, 2024

Thank you @jdecool !

@mremi
Copy link
Member

mremi commented Nov 13, 2024

And a new fresh release https://github.com/ekino/phpstan-banned-code/releases/tag/v3.0.0

@jdecool jdecool deleted the phpstan2 branch November 13, 2024 10:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants