Added HelpDialog, TranslateDialog. Deleted IAmDialog. Renamed ChitChat to None. Added UserEmotion to UserInfoDialog #24

kpstrawn · 2017-07-25T17:00:32Z

No description provided.

jsy1218-zz

We need to change back from NoneDialog to ChitChatDialog class name
We need to evaluate all the introduced intents, how to handle them in the code
We need to evaluate if IAm intent should be deleted. I feel this is one of the most important intents.

jsy1218-zz · 2017-07-26T06:44:18Z

DTML.EduBot/Dialogs/GreetingDialog.cs

@@ -9,13 +9,14 @@

 namespace DTML.EduBot.Dialogs
 {
-    public partial class ChitChatDialog : QnaLuisDialog<object>
+    public partial class NoneDialog : QnaLuisDialog<object>


The class name should not be changed to NoneDialog. Right now ChitChatDialog reflects the fact the bot will try its best to respond.

Plus ChitChatDialog is a partial class that is shared for all different intents.

Why did we rename this? did we change the functionality from chit chat, to handling only "None" intents?

jsy1218-zz · 2017-07-26T06:44:38Z

DTML.EduBot/Dialogs/GreetingDialog.cs

    {
        [LuisIntent("Greeting")]
        public async Task Greeting(IDialogContext context, LuisResult result)
        {
            string botresponse = BotPersonality.GetRandomGreeting(); 
            await context.PostAsync(botresponse);
+


remove blank space

jsy1218-zz · 2017-07-26T06:45:08Z

DTML.EduBot/Dialogs/HelpDialog.cs

+        [LuisIntent("Help")]
+        public async Task HandleHelpIntent(IDialogContext context, LuisResult result)
+        {
+            await context.PostAsync("");


Non-empty response. This is for user experience.

jsy1218-zz · 2017-07-26T06:45:48Z

DTML.EduBot/Dialogs/IAmDialog.cs

-
-namespace DTML.EduBot.Dialogs
-{
-    public partial class ChitChatDialog : QnaLuisDialog <Object>


Why IAm intent got removed?

jsy1218-zz · 2017-07-26T06:46:35Z

DTML.EduBot/Dialogs/NoneDialog.cs

-        {
-            await context.SayAsync(BotPersonality.BotResponseToGibberish, BotPersonality.BotResponseToGibberish);
-        }
+       //[LuisIntent("Gibberish")]


Why commenting out? If not in use, we should delete the code block.

With that said, should this code block still function?

a part of the code that is commented out is called "Dead Code". I assume this was left over while testing the code. Dead code should be removed before code check in.

jsy1218-zz · 2017-07-26T06:49:17Z

DTML.EduBot/Dialogs/TranslateDialog.cs

+{
+    public partial class HelpDialog : QnaLuisDialog<object>
+    {
+        [LuisIntent("Translate")]


Why Translate intent? Right now we have a translate API in place. Plus, if the user needs help, it should be handled by help intent, followed by yes/no choice, and then we call translate API.

We can use translate intent to explicitly ask for translation of a phase. e.g. while learning talking to the bot in English, the student can ask for translation of a specific phrase without changing the system language.

Can we implement the call to translation api here?

jsy1218-zz · 2017-07-26T06:49:43Z

DTML.EduBot/Dialogs/UserInformation.cs

+        [LuisIntent("UserEmotion")]
+        public async Task HandleUserEmotion(IDialogContext context, LuisResult result)
+        {
+            await context.PostAsync("");


How do you plan to handle UserEmotion? Reply with Emoji?

eklavyamirani

Great work so far. Needs a few changes before we can merge this (check comments)

eklavyamirani · 2017-07-30T21:52:51Z

DTML.EduBot/Common/UserInformation.cs

+using System.Linq;
+using System.Web;
+
+namespace DTML.EduBot.Common


Should be in Models, not Common

eklavyamirani · 2017-07-30T21:53:15Z

DTML.EduBot/Constants/BotEntities.cs

@@ -12,7 +12,30 @@ public static class BotEntities
        public static string Time = "time";
        public static string Date = "date";
        public static string Color = "color";
-        public static string Subject = "subject";
+        public static string Subject = "Subject";


static string -> const string

eklavyamirani · 2017-07-30T21:55:12Z

DTML.EduBot/Dialogs/GreetingDialog.cs

@@ -9,13 +9,14 @@

 namespace DTML.EduBot.Dialogs
 {
-    public partial class ChitChatDialog : QnaLuisDialog<object>
+    public partial class NoneDialog : QnaLuisDialog<object>


Why did we rename this? did we change the functionality from chit chat, to handling only "None" intents?

eklavyamirani · 2017-07-30T21:56:47Z

DTML.EduBot/Dialogs/NoneDialog.cs

-        {
-            await context.SayAsync(BotPersonality.BotResponseToGibberish, BotPersonality.BotResponseToGibberish);
-        }
+       //[LuisIntent("Gibberish")]


a part of the code that is commented out is called "Dead Code". I assume this was left over while testing the code. Dead code should be removed before code check in.

eklavyamirani · 2017-07-30T21:58:48Z

DTML.EduBot/Dialogs/TranslateDialog.cs

+{
+    public partial class HelpDialog : QnaLuisDialog<object>
+    {
+        [LuisIntent("Translate")]


We can use translate intent to explicitly ask for translation of a phase. e.g. while learning talking to the bot in English, the student can ask for translation of a specific phrase without changing the system language.

Can we implement the call to translation api here?

eklavyamirani · 2017-07-30T21:59:56Z

DTML.EduBot/Dialogs/TranslateDialog.cs

+        [LuisIntent("Translate")]
+        public async Task HandleTranslateIntent(IDialogContext context, LuisResult result)
+        {
+            await context.PostAsync("");


all the await context.PostAsync(""); statement should send back non empty messages before we can merge these changes. Can you change these?

Kylie Strawn added 5 commits July 25, 2017 09:36

Add Help Dialog

cabbaab

Rename chitchat dialog to none. Delete IAm dialog

2c54e8c

Add Translate Dialog

e233b69

Add User Emotion to User Info

2f831ec

Add greetings, bot entities, created userinformation class

9c2a5ad

jsy1218-zz reviewed Jul 26, 2017

View reviewed changes

eklavyamirani requested changes Jul 30, 2017

View reviewed changes

eklavyamirani added the Waiting for author label Jul 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added HelpDialog, TranslateDialog. Deleted IAmDialog. Renamed ChitChat to None. Added UserEmotion to UserInfoDialog #24

Added HelpDialog, TranslateDialog. Deleted IAmDialog. Renamed ChitChat to None. Added UserEmotion to UserInfoDialog #24

kpstrawn commented Jul 25, 2017

jsy1218-zz left a comment

jsy1218-zz Jul 26, 2017

eklavyamirani Jul 30, 2017

jsy1218-zz Jul 26, 2017

jsy1218-zz Jul 26, 2017

jsy1218-zz Jul 26, 2017

jsy1218-zz Jul 26, 2017

eklavyamirani Jul 30, 2017

jsy1218-zz Jul 26, 2017

eklavyamirani Jul 30, 2017

jsy1218-zz Jul 26, 2017

eklavyamirani left a comment

eklavyamirani Jul 30, 2017

eklavyamirani Jul 30, 2017

eklavyamirani Jul 30, 2017

eklavyamirani Jul 30, 2017

eklavyamirani Jul 30, 2017

eklavyamirani Jul 30, 2017

Added HelpDialog, TranslateDialog. Deleted IAmDialog. Renamed ChitChat to None. Added UserEmotion to UserInfoDialog #24

Are you sure you want to change the base?

Added HelpDialog, TranslateDialog. Deleted IAmDialog. Renamed ChitChat to None. Added UserEmotion to UserInfoDialog #24

Conversation

kpstrawn commented Jul 25, 2017

jsy1218-zz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eklavyamirani left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment