Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Correct format of Bearer authentication header #393

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

stefano-pogliani
Copy link
Contributor

Hi 👋

I recently noticed that around the 21st of August the exporter stopped refreshing my heating information.

I discovered the issue is around failing to authenticate.
Executing the same API calls the exporter performs in another REST client worked.
The only difference between the request is Bearer: (from the code) vs Bearer (from my REST client).

This PR removes the : after Bearer in the authentication header, which fixes the issue.
Looking at the RFC the : is not expected.

Given this broke without changes on my side I expect Tado updated their systems and new version rejects Bearer: while the old one allowed it 🤷

I hope this helps and thanks for the useful project,
Stefano

@gyulaasztalos
Copy link

Thank you for sharing this fix. Working great!

@zearthlink
Copy link

Thanks, the fix works great

@squeeb
Copy link

squeeb commented Dec 1, 2024

Confirmed working

Copy link
Owner

@eko eko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stefano-pogliani

@eko eko merged commit a03d110 into eko:master Dec 1, 2024
@stefano-pogliani stefano-pogliani deleted the fix-auth branch December 1, 2024 21:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants