fix: Correct format of Bearer authentication header #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I recently noticed that around the 21st of August the exporter stopped refreshing my heating information.
I discovered the issue is around failing to authenticate.
Executing the same API calls the exporter performs in another REST client worked.
The only difference between the request is
Bearer:
(from the code) vsBearer
(from my REST client).This PR removes the
:
afterBearer
in the authentication header, which fixes the issue.Looking at the RFC the
:
is not expected.Given this broke without changes on my side I expect Tado updated their systems and new version rejects
Bearer:
while the old one allowed it 🤷I hope this helps and thanks for the useful project,
Stefano