Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve test coverage #166

Closed
richardcase opened this issue Aug 20, 2018 · 3 comments
Closed

Improve test coverage #166

richardcase opened this issue Aug 20, 2018 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request

Comments

@richardcase
Copy link
Contributor

richardcase commented Aug 20, 2018

Why do you want this feature?
We need to improve the test coverage so that we have confidence in the effect of changes.

What feature/behavior/change do you want?
The test (unit tests) coverage should be increased. We should initially aim for around 60% coverage.

This is a follow on from #46 where we introduced the testing strategy.

This was referenced Aug 20, 2018
@richardcase richardcase added kind/feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 20, 2018
@richardcase richardcase changed the title Test coverage to 60% Improve test coverage Aug 22, 2018
@mumoshu
Copy link
Contributor

mumoshu commented Jan 13, 2019

@errordeveloper Could you enable codecov once again, so that we can better track deltas in the test coverage?

I see the codecov project is already there. But it seems to not have updated for months.

https://coveralls.io/github/weaveworks/eksctl?branch=master

@errordeveloper
Copy link
Contributor

I'm not sure what broken, this needs to be looked into.

@errordeveloper
Copy link
Contributor

errordeveloper commented May 13, 2019

I think we are in a better place now, but per-package coverage can be improved. I'm don't see a good reason to keep this issue open as is. I maybe a good idea to review the state of testing and open separate issue, otherwise I'm happy to just keep on improving every time we touch the test suite.

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants