Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for overrideBootstrapCommand in AL2023 #8078

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Dec 9, 2024

Description

Overriding bootstrapping in AL2023 is achieved by providing your own nodeConfig, which will be merged with the default one (created either by eksctl for self-managed nodes and customAMIs, or by EKS MNG, for eks-managed nodes based on native AMIs).

Please refer to userdocs -https://github.com/eksctl-io/eksctl/blob/main/userdocs/src/usage/node-bootstrapping.md

Closes #7852
Closes #8037
Closes #8043
Closes #7895

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the kind/feature New feature or request label Dec 9, 2024
@TiberiuGC TiberiuGC changed the title Feature/al2023 overridebootstrap Add support for overrideBootstrapCommand in AL2023 Dec 9, 2024
@TiberiuGC TiberiuGC force-pushed the feature/al2023-overridebootstrap branch from 52d53b0 to a7ff8ad Compare December 9, 2024 17:08
a-hilaly
a-hilaly previously approved these changes Dec 9, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-hilaly
Copy link
Member

a-hilaly commented Dec 9, 2024

discussed with @TiberiuGC regarding e2e tests. Pending more information on how we are testing these in the github actions

@TiberiuGC TiberiuGC force-pushed the feature/al2023-overridebootstrap branch from 36c0886 to 3247d70 Compare December 10, 2024 16:12
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TiberiuGC !

@TiberiuGC TiberiuGC merged commit ad8c326 into eksctl-io:main Dec 10, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment