Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate goformation under pkg/ as a local package and remove location re-write #8153

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

bryantbiggs
Copy link
Member

Description

  • Migrate goformation under pkg/ as a local package and remove location re-write
    • This removes the second set of dependencies and treats it as a local package, not a remote module

The steps used to create this PR are as follows (to better understand due to large number of path re-write changes):

  1. Move the goformation directory under pkg/
  2. Remove the goformation references from the main go.mod file
  3. Remove go.mod and go.sum from pkg/goformation/*
  4. Re-write paths for goformation (find ./ -type f -name '*.go' -exec sed -i 's|awslabs/goformation/v4|weaveworks/eksctl/pkg/goformation|g' {} \;)
  5. Run go mod tidy
  6. Run make build
  7. Run make unit-test-no-generate to test

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs bryantbiggs added skip-release-notes Causes PR not to show in release notes dependencies Pull requests that update a dependency file area/tech-debt Leftover improvements in code, testing and building labels Jan 21, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bryantbiggs bryantbiggs merged commit d0e5360 into eksctl-io:main Jan 21, 2025
10 checks passed
@bryantbiggs bryantbiggs deleted the chore/goformation-pkg branch January 21, 2025 17:42
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Jan 22, 2025
TiberiuGC added a commit that referenced this pull request Jan 22, 2025
)

* Revert "Bump github.com/gofrs/flock from 0.8.1 to 0.12.1 (#8024)"

This reverts commit 18394bd.

* Revert "Bump github.com/github-release/github-release from 0.10.0 to 0.10.1 (#8107)"

This reverts commit 34ab1f8.

* Revert "Migrate `goformation` under `pkg/` as a local package and remove location re-write (#8153)"

This reverts commit d0e5360.

* Revert "Upgrade to go 1.22 (#8125)"

This reverts commit ccdd44c.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants