Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

more fuzz tests #667

Open
2 tasks
pca006132 opened this issue Dec 20, 2023 · 7 comments
Open
2 tasks

more fuzz tests #667

pca006132 opened this issue Dec 20, 2023 · 7 comments

Comments

@pca006132
Copy link
Collaborator

We only have tests for the triangulator, and the test is only checking for segfault/memory corruption and infinite loops. We should add more tests.

  1. Add tests for the triangulator with valid polygons.
  2. Add tests for CSG.

CSG can be fuzzed with a simple grammar.

@pca006132
Copy link
Collaborator Author

@elalish
Copy link
Owner

elalish commented Apr 16, 2024

@dasoya - regarding your GSoC proposal, would you be up for writing a short introductory PR so we can get to know you better?

@dasoya
Copy link
Contributor

dasoya commented Apr 17, 2024 via email

@elalish
Copy link
Owner

elalish commented Apr 17, 2024

@dasoya That's wonderful, and we'd certainly appreciate your contributions! From the GSoC side, they're much more willing to accept those who have demonstrated successful contribution to the code base. If you'd be willing to open a simple PR we can review and merge, it'll go a long way. If you're not sure where to start, a simple task we've been meaning to get around to is splitting our tests into more files - there are so many now that the granularity is much too coarse. If you'd like to take a stab at organizing some of them a bit, we'd certainly appreciate it.

@dasoya
Copy link
Contributor

dasoya commented Apr 17, 2024 via email

@dasoya
Copy link
Contributor

dasoya commented Apr 23, 2024

@elalish As you suggested, I thought boolean_test.cpp has high complexity, so I divided it into two files.
I'm going to make additional boolean tests in the complex_boolen_test.cpp or new fuzz test file.

master...dasoya:manifold:boolean_fuzz

Is this the right way? Let me know what you think.

@elalish
Copy link
Owner

elalish commented Apr 23, 2024

Yes, that's a great start - go ahead and open a PR. It's always best to have many, smaller PRs anyway, and it gives us a good place to discuss.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants