Add NumVert, NumContour, and Warp #370
Conversation
| EXPECT_EQ(sq.NumVert(), 4); | ||
| EXPECT_EQ(sq.NumContour(), 1); | ||
| Identical(Manifold::Extrude(a, 1.).GetMesh(), | ||
| Manifold::Extrude(b, 1.).GetMesh()); |
Ok, I'll add that in then 👍 |
| @@ -305,6 +305,24 @@ CrossSection CrossSection::Transform(const glm::mat3x2& m) const { | |||
| return transformed; | |||
| } | |||
|
|
|||
| CrossSection CrossSection::Warp( | |||
There was a problem hiding this comment.
Also, either now or in a follow-on PR, would you mind adding docs to these functions? The CrossSection docs are looking a little sparse.
There was a problem hiding this comment.
Sure, I'll make that my next PR.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 85.37% 85.45% +0.08%
==========================================
Files 36 36
Lines 4375 4393 +18
==========================================
+ Hits 3735 3754 +19
+ Misses 640 639 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
A few more methods to
CrossSectionto bring it another step in line withManifold.Warp, do you guys think that it should go through a union to clean up any user induced shenanigans, or leave it be (similar to Manifold).