GLM 1.0 compatibility #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using glm/gtx/compatibility.hpp without GLM_ENABLE_EXPERIMENTAL has
become an error:
error: #error "GLM: GLM_GTX_compatibility is an experimental extension
and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL
before including it, if you really want to use it."
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 37 37
Lines 4732 4732
=======================================
Hits 4338 4338
Misses 394 394 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Using glm/gtx/compatibility.hpp without GLM_ENABLE_EXPERIMENTAL has
become an error:
error: #error "GLM: GLM_GTX_compatibility is an experimental extension
and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL
before including it, if you really want to use it."
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using glm/gtx/compatibility.hpp without GLM_ENABLE_EXPERIMENTAL has become an error:
Became an error in:
g-truc/glm@f86092a#diff-b25c43cdda0d7be5dc5ea91beefb168cc1bd2522d60c7aa9b6c6164c0630e173
I haven't noticed any other effects from defining GLM_ENABLE_EXPERIMENTAL. But...