optimize triangulator for msvc #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 91.67% 91.65% -0.02%
==========================================
Files 37 37
Lines 4732 4734 +2
==========================================
+ Hits 4338 4339 +1
- Misses 394 395 +1 ☔ View full report in Codecov by Sentry. |
|
@pca006132 You want just Windows, or Windows and Mac. |
|
@briansturgill just windows is fine |
|
@pca006132 Good news... several runs, results in range 1500-1600 over 4x performance boost. |
|
Nice! Thanks a lot. Btw feel free to open discussions if you find other potential performance issues, even if they are platform specific. Tracy is a useful tool to find such issues. |
|
Good find! |
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
optimize for msvc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that msvc does not optimize
glm::determinant(glm::mat2(a, b))well, it requires an intermediate struct that is stored in the stack, causing performance issues. This patch improves the performance of the test in #718 from 5s to 2s on Windows, and no performance degradation with clang/gcc.@briansturgill maybe you can test this as well, I am using a windows vm so the performance number may not be that accurate.