Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test windows dll build #743

Merged
merged 15 commits into from
Feb 15, 2024
Merged

test windows dll build #743

merged 15 commits into from
Feb 15, 2024

Conversation

pca006132
Copy link
Collaborator

@pca006132 pca006132 commented Feb 15, 2024 •
edited
Loading

re. #359

Also closes #731.

@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4395ab6) 91.67% compared to head (e91603e) 91.67%.

❗ Current head e91603e differs from pull request most recent head 65577f8. Consider uploading reports for the commit 65577f8 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #743   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          37       37           
  Lines        4722     4722           
=======================================
  Hits         4329     4329           
  Misses        393      393

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elalish
elalish approved these changes Feb 15, 2024
View reviewed changes
Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@elalish
Copy link
Owner

elalish commented Feb 15, 2024

I hate windows too, and I used to work on it...

@elalish elalish merged commit f3c5ada into elalish:master Feb 15, 2024
16 checks passed
@pca006132 pca006132 deleted the test-dll branch February 15, 2024 23:33
@edumarzolla
Copy link

I finally got success compiling the DLL in VS2022... thanks...
But I miss the ExportMesh is missing on this compiled DLL.
My objetive is to create two cylinders, move one, subtract them, translate, rotate, scale and export it as glb file

@elalish
Copy link
Owner

elalish commented Feb 24, 2024

Did you enable the MANIFOLD_EXPORT build flag? https://www.iab.com/news/iab-and-mrc-release-augmented-reality-measurement-guidelines-for-public-comment/

cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
@pca006132
test windows dll build (elalish#743)
df482a3 
* test windows dll build

* export all symbols on windows

* skip manifoldc_test on emscripten

* try fix windows build

* fix

* fix2

* fix manifoldc on emscripten

* fix

* fix manifoldc

* fixes

* fix windows ci

* fix python flags

* document windows shenanigans

* I hate windows

* tell users we are downloading thrust from source
@edumarzolla
Copy link

Dear team,
Do you have plans to insert the shared libraries to the Windows Shenanigans DLL compilation?
It would be great to have a DLL that could be used by any Windows software such as C#.
Thanks!

@elalish
Copy link
Owner

elalish commented Jul 17, 2024

I know next to nothing about Windows DLL shenanigans, but we definitely want our library to be as easy to use across platforms and languages as possible. I think someone else also suggested vcpkg. PRs welcome! Almost all of our language bindings and platform support have come from different contributors; I couldn't have done it alone. Do you have the know-how?

@edumarzolla
Copy link

edumarzolla commented Jul 17, 2024 via email

@pca006132
Copy link
Collaborator Author

Hmmm, what is Windows Shenanigans DLL compilation?

@edumarzolla
Copy link

edumarzolla commented Jul 18, 2024 via email

@pca006132
Copy link
Collaborator Author

Oh you mean you want the CI to upload the compiled DLL? I thought "Windows Shenanigans DLL compilation" is some sort of a package manager or something :P

@edumarzolla
Copy link

edumarzolla commented Jul 18, 2024 via email

@elalish
Copy link
Owner

elalish commented Jul 18, 2024

Your terminology is a bit vague. Can you point to another library that is packaged the way you desire so we can understand better? And where would these DLLs live?

@edumarzolla
Copy link

edumarzolla commented Jul 18, 2024 via email

@pca006132
Copy link
Collaborator Author

The question is: What problem are you facing when building on windows? What do you mean by

already got success compiling according the readme, but the current version do not have the shared libraries available, so the current version does not work by itself.

What output did you get?

@edumarzolla
Copy link

edumarzolla commented Jul 18, 2024 via email

@edumarzolla
Copy link

edumarzolla commented Jul 18, 2024 via email

@pca006132
Copy link
Collaborator Author

Sorry but I cannot see your error message screenshot. And maybe you can put it in a new discussion to see if someone knows this?

@elalish
Copy link
Owner

elalish commented Jul 18, 2024

Yeah, I think what you're trying to say is you need a little help linking our lib into C#. Agreed that a new discussion would be a better place for that. And please try to find the most useful parts of your error spew to show us instead of pasting pages worth in here. Perhaps you can ask in #551

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake silently downloads Thrust
3 participants
@pca006132 @elalish @edumarzolla