Http errors #183
Merged
Http errors #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LikeTheSalad you make want to add something similar for the android agent. |
| span.addEvent(name : SemanticAttributes.exception.rawValue, | ||
| attributes: [SemanticAttributes.exceptionType.rawValue: AttributeValue.string("\(httpResponse.statusCode)"), | ||
| SemanticAttributes.exceptionEscaped.rawValue: AttributeValue.bool(false), | ||
| SemanticAttributes.exceptionMessage.rawValue: AttributeValue.string(HTTPURLResponse.localizedString(forStatusCode: httpResponse.statusCode)), |
There was a problem hiding this comment.
Just to try to keep things consistent in Android, what's the message format provided by HTTPURLResponse.localizedString(forStatusCode: httpResponse.statusCode)?
There was a problem hiding this comment.
for a 404 this produces "Not Found"
It's using the string values described in RFC 2616
LikeTheSalad
approved these changes
Oct 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an "error" for http errors, which will then show up in the errors tab of the UI.