Skip to content

fix: capture route from base on express app.use #3631

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

isikhi
Copy link

@isikhi isikhi commented Sep 20, 2023

Closes: #3630

The error mentioned in the issue has been corrected.

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 20, 2023

❌ Author of the following commits did not sign a Contributor Agreement:
c8cf0b9,

Please, read and sign the above mentioned agreement if you want to contribute to this project

@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels Sep 20, 2023
@isikhi isikhi closed this Sep 20, 2023
@isikhi isikhi reopened this Sep 20, 2023
@isikhi
Copy link
Author

isikhi commented Sep 20, 2023

I signed CLA after the merge request opened, is there any problem with CLA synchronization?

Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cla/check

@isikhi
Copy link
Author

isikhi commented Nov 21, 2023

I signed CLA a few times but could not completed this step idk why. I signed with github related email but i am not sure why it is not completed 🤔 Any help ? Or maybe you can cherry pick my changes these are a few little changes.

@david-luna
Copy link
Member

Hi @isikhi

about the CLA you may want to send an email to cla-questions@elastic.co

also I want to ask if you checked my last comment on #3630. The sample you provided has the require('express') before the require('elastic-apm-node').start(...)so that agent is too late to instrument the express framework.

Please confirm you have tested your sample with require('elastic-apm-node').start(...) at the top of the file and see the same behavior. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
agent-nodejs Make available for APM Agents project planning. community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not capture transaction name on multi-middleware
3 participants